Skip to content

[math/RF] Reduce test failures when ROOT is built without clad or gsl #20027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[math/RF] Reduce test failures when ROOT is built without clad or gsl #20027

wants to merge 5 commits into from

Conversation

hageboeck
Copy link
Member

When working with ROOT where some features were off, I encountered test failures. These commits reduce some of those, namely:

  • Add fallbacks to other RooFit backends when clad is off. The tests continue to run also with the numeric backend.
  • When selecting an unsupported algorithm in RootFinder, throw an exception instead of crashing.

@hageboeck hageboeck self-assigned this Oct 3, 2025
guitargeek
guitargeek requested changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I only have one request about the tutorial

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

Test Results

    20 files      20 suites   3d 12h 3m 48s ⏱️
 3 691 tests  3 691 ✅ 0 💤 0 ❌
72 029 runs  72 029 ✅ 0 💤 0 ❌

Results for commit bb9bb18.

♻️ This comment has been updated with latest results.

guitargeek
guitargeek approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@hageboeck hageboeck requested a review from guitargeek October 3, 2025 13:42
vgvassilev
vgvassilev reviewed Oct 7, 2025
View reviewed changes
hageboeck and others added 2 commits October 8, 2025 18:10
@hageboeck
[RF] Make testRooMulti independent of clad.
e7776f5 
When clad is off, the tests were failing. With the standard backend,
they run fine, though.
All backends are tested in parametrised tests, so testRooMulti can be
made independent of any backend.
@hageboeck @guitargeek
[RF] Make tutorial r619 runnable without clad.
90d16c7 
Also fix a warning that protects from a Gaussian with sigma=0.

Co-authored-by: Jonas Rembser <[email protected]>
@hageboeck hageboeck requested a review from guitargeek October 8, 2025 16:13
guitargeek
guitargeek approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It makes sense to have a clear error and a fallback instead of a crash

@hageboeck
[math] Throw exception when RootFinder is constructed with invalid algo.
a976427 
When MathMore cannot be loaded, the tutorial exampleFunction.py used to
crash. Here, a throw is added to the constructor, which is caught in the
Python tutorial.
@hageboeck
[tutorials] Apply ruff suggestions to exampleFunction.py
2ef0113
@hageboeck
[RF] Add fallback to RooFit's EvalBackend when built without clad.
bb9bb18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev left review comments

@guitargeek guitargeek guitargeek approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

Assignees

@hageboeck hageboeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hageboeck @vgvassilev @guitargeek